Conversation
johnkerl
force-pushed
the
kerl/py-r-ugr-dom
branch
3 times, most recently
from
2de8c24 to
9ea23eb
Compare
johnkerl
changed the title
upgrade_domainupgrade_domain
johnkerl
force-pushed
the
kerl/py-r-ugr-dom
branch
from
3bc8bdb to
7787ee8
Compare
johnkerl
force-pushed
the
kerl/prefixing
branch
from
5dc298d to
01e22d6
Compare
johnkerl
force-pushed
the
kerl/py-r-ugr-dom
branch
from
7787ee8 to
1ded11f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3235 +/- ##
==========================================
- Coverage 83.88% 83.84% -0.05%
==========================================
Files 51 51
Lines 5512 5557 +45
==========================================
+ Hits 4624 4659 +35
- Misses 888 898 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
reviewed
Oct 25, 2024
johnkerl
force-pushed
the
kerl/py-r-ugr-dom
branch
4 times, most recently
from
95182e3 to
a59204c
Compare
Contributor
Author
|
@nguyenv ready for next round! |
johnkerl
force-pushed
the
kerl/py-r-ugr-dom
branch
from
a59204c to
b28d022
Compare
nguyenv
approved these changes
Oct 28, 2024
Contributor
Author
|
Thanks @nguyenv ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Connects #3220 to the Python user-facing layers.
Notes for Reviewer:
I was going to do Python+R on a single PR but the line count is ~400 which is enough (IMO) so I'll make a separate for R -- cc @mojaveazure