Skip to content

[ci] Run R/Python interop tests with new-shape flag off/on#3232

Merged
johnkerl merged 2 commits intomainfrom
kerl/ff-interop
Oct 24, 2024
Merged

[ci] Run R/Python interop tests with new-shape flag off/on#3232
johnkerl merged 2 commits intomainfrom
kerl/ff-interop

Conversation

@johnkerl
Copy link
Copy Markdown
Contributor

@johnkerl johnkerl commented Oct 24, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Changes:

We have four unit-test suites: C++ in libtiledbsoma/test; Python in apis/python/tests; R in apis/r/tests/testthat; R/Python interop in apis/system/tests.

I found on #3230 that while I'd been running C++, Python, and R CI "both ways", I'd not been doing the same for R/Python interop testing. This PR fixes that.

Notes for Reviewer:

#3230 goes on top of this

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (99ba3a3) to head (46ab54f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3232      +/-   ##
==========================================
+ Coverage   83.86%   83.97%   +0.10%     
==========================================
  Files          51       51              
  Lines        5505     5505              
==========================================
+ Hits         4617     4623       +6     
+ Misses        888      882       -6     
Flag Coverage Δ
python 83.97% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.97% <ø> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl marked this pull request as ready for review October 24, 2024 04:17
@johnkerl johnkerl changed the title [ci] Run R/Python interop tests with new/shape flag off/on [WIP] [ci] Run R/Python interop tests with new/shape flag off/on Oct 24, 2024
@johnkerl johnkerl merged commit dd2a418 into main Oct 24, 2024
@johnkerl johnkerl deleted the kerl/ff-interop branch October 24, 2024 15:18
@johnkerl johnkerl changed the title [ci] Run R/Python interop tests with new/shape flag off/on [ci] Run R/Python interop tests with new-shape flag off/on Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants