Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3220 +/- ##
==========================================
+ Coverage 83.86% 83.97% +0.10%
==========================================
Files 51 51
Lines 5505 5505
==========================================
+ Hits 4617 4623 +6
+ Misses 888 882 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/cpp-ugr-dom-2
branch
from
6a0130c to
c600499
Compare
johnkerl
force-pushed
the
kerl/cpp-ugr-dom-2
branch
from
c600499 to
d4a5c3c
Compare
This was referenced Oct 24, 2024
johnkerl
force-pushed
the
kerl/cpp-ugr-dom-2
branch
from
d4a5c3c to
c9d3044
Compare
johnkerl
force-pushed
the
kerl/cpp-ugr-dom-2
branch
from
27b8e60 to
c5df336
Compare
Contributor
Author
|
@nguyenv this was inadvertently included in my merge of #3236. My mistake:
Given that #3236 was approved and others underneath it were not, and that #3236 didn't depend crucially on #3220 or #3234, I switched #3236 to be a merge into Happy to re-open this PR for discussion if you like. My apologies again for the misstep and the confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
upgrade_domainforSOMADataFrameat the C++ levelNotes for Reviewer:
This PR is a work in progress. It is not ready for review.