[c++] Geometry Dataframe#3212
Merged
XanthosXanthopoulos merged 2 commits intomainfrom Nov 6, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3212 +/- ##
==========================================
+ Coverage 83.86% 83.97% +0.10%
==========================================
Files 51 51
Lines 5505 5505
==========================================
+ Hits 4617 4623 +6
+ Misses 888 882 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
XanthosXanthopoulos
requested review from
johnkerl,
jp-dark and
nguyenv
and removed request for
jp-dark and
nguyenv
jp-dark
reviewed
Oct 23, 2024
Collaborator
jp-dark
left a comment
jp-dark
left a comment
There was a problem hiding this comment.
That parts of this I understand look good to me, but I'm not familiar enough with the arrow adapter code to have a good sense of what impact the change might have there.
johnkerl
suggested changes
Oct 23, 2024
nguyenv
reviewed
Oct 23, 2024
XanthosXanthopoulos
force-pushed
the
xan/geometry_dataframe_cpp
branch
from
02bfa69 to
ead7104
Compare
nguyenv
approved these changes
Oct 28, 2024
Contributor
nguyenv
left a comment
nguyenv
left a comment
There was a problem hiding this comment.
I think this look good! Maybe wait for one more approval since it's a larger PR though.
johnkerl
approved these changes
Nov 5, 2024
| const std::string ENCODING_VERSION_KEY = "soma_encoding_version"; | ||
| const std::string ENCODING_VERSION_VAL = "1.1.0"; | ||
| const std::string SOMA_GEOMETRY_COLUMN_NAME = "soma_geometry"; | ||
| const std::string SOMA_GEOMETRY_DIMENSION_PREFIX = "tiledb__internal__"; |
Contributor
There was a problem hiding this comment.
Suggested change
| const std::string SOMA_GEOMETRY_DIMENSION_PREFIX = "tiledb__internal__"; | |
| const std::string SOMA_GEOMETRY_DIMENSION_PREFIX = "tiledb_internal__"; |
johnkerl
pushed a commit
that referenced
this pull request
Nov 6, 2024
* Geometry dataframe implementation, use spatial axes when available when creating schema * Address PR review comments
johnkerl
added a commit
that referenced
this pull request
Nov 6, 2024
* Geometry dataframe implementation, use spatial axes when available when creating schema * Address PR review comments Co-authored-by: XanthosXanthopoulos <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new
SOMAGeometryDataFrameobject. This new object requires spatial axes to be determined and uses them internally to index geometry objects stored as a WKB encoded attribute. To differentiate between binary attributes and WKB binary attributes the Arrow schema requires adtypemetadata key with the valueWKB.