Skip to content

[c++] can_upgrade_domain#3211

Merged
johnkerl merged 4 commits intomainfrom
kerl/cpp-ugr-dom
Oct 23, 2024
Merged

[c++] can_upgrade_domain#3211
johnkerl merged 4 commits intomainfrom
kerl/cpp-ugr-dom

Conversation

@johnkerl
Copy link
Copy Markdown
Contributor

@johnkerl johnkerl commented Oct 21, 2024 •
edited
Loading

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

  • This is can_upgrade_domain for SOMADataFrame at the C++ level

Notes for Reviewer:

@johnkerl johnkerl mentioned this pull request Oct 21, 2024
Closed
@johnkerl johnkerl force-pushed the kerl/cpp-ugr-dom branch 3 times, most recently from 9cf054f to f19350c Compare October 21, 2024 14:08
@johnkerl johnkerl changed the title [c++] upgrade_domain [WIP] [c++] upgrade_domain Oct 22, 2024
@johnkerl johnkerl requested review from jp-dark and nguyenv October 22, 2024 23:31
@johnkerl johnkerl marked this pull request as ready for review October 22, 2024 23:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (467cd7b) to head (bc8d143).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3211      +/-   ##
==========================================
+ Coverage   83.54%   83.91%   +0.36%     
==========================================
  Files          51       51              
  Lines        5434     5478      +44     
==========================================
+ Hits         4540     4597      +57     
+ Misses        894      881      -13
Flag Coverage Δ
python 83.91% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.91% <ø> (+0.36%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl changed the title [c++] upgrade_domain [c++] can_upgrade_domain Oct 23, 2024
nguyenv
nguyenv approved these changes Oct 23, 2024
View reviewed changes
Comment thread libtiledbsoma/src/soma/soma_array.cc Outdated
Comment thread libtiledbsoma/src/soma/soma_array.h
@johnkerl johnkerl merged commit 09e1b6c into main Oct 23, 2024
@johnkerl johnkerl deleted the kerl/cpp-ugr-dom branch October 23, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jp-dark jp-dark Awaiting requested review from jp-dark

1 more reviewer

@nguyenv nguyenv nguyenv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnkerl @nguyenv