[r] Min-sizing for dataframes/arrays with new shape feature#3208
Merged
[r] Min-sizing for dataframes/arrays with new shape feature#3208
Conversation
johnkerl
force-pushed
the
kerl/r-min-sizing
branch
9 times, most recently
from
751ebe4 to
02a53be
Compare
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/r-min-sizing
branch
from
02a53be to
c2f0894
Compare
mojaveazure
approved these changes
Oct 20, 2024
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
LGTM; please update the changelog, bump the develop version, and 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
In the design at #2407 we decided that
Noneno longer means "as big a domain as possible" but now rather "as small as possible" -- as only upward resizes, not downward resizes, are possible. This is a breaking change we have already agreed on.This is the R counterpart to the Python PRs #3190 #3191 #3192 #3193 #3194 #3203. I didn't split this one up into multiple PRs as I did those. However, the mods are the same:
domainatcreatedomainbeingNULLoverall or slotwise makes smallest-possible rather than largest-possible.Notes for Reviewer: