Skip to content

[python] Min-sizing for dataframes/arrays [no merge]#3189

Closed
johnkerl wants to merge 18 commits intomainfrom
kerl/min-size
Closed

[python] Min-sizing for dataframes/arrays [no merge]#3189
johnkerl wants to merge 18 commits intomainfrom
kerl/min-size

Conversation

@johnkerl
Copy link
Copy Markdown
Contributor

@johnkerl johnkerl commented Oct 17, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

In the agreed-on design at #2407 we agreed that None no longer means "as big a domain as possible" but now rather "as small as possible". This is a breaking change we have already agreed on.

On this PR -- not to be merged -- I've made the mods to the dataframe/array classes as well as unit-test cases. The result is many many lines -- too many.

This PR will be split up into several pieces, and then ultimately abandoned. It is posted here at all (a) for transparency; (b) for a CI check; (c) for bus-factor avoidance.

Notes for Reviewer:

This PR will be split up into several pieces, and then ultimately abandoned. It is posted here at all (a) for transparency; (b) for a CI check; (c) for bus-factor avoidance.

@johnkerl
Copy link
Copy Markdown
Contributor Author

Replaced by #3203

@johnkerl johnkerl closed this Oct 18, 2024
@johnkerl johnkerl deleted the kerl/min-size branch November 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant