[python] Canned tests for old/new arrays without/with new shapes#3156
Merged
[python] Canned tests for old/new arrays without/with new shapes#3156
Conversation
johnkerl
force-pushed
the
kerl/py-exp-shaping
branch
from
84516ba to
880e26b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3156 +/- ##
==========================================
+ Coverage 82.92% 83.13% +0.20%
==========================================
Files 50 50
Lines 5236 5247 +11
==========================================
+ Hits 4342 4362 +20
+ Misses 894 885 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Oct 9, 2024
Contributor
Author
|
Thanks @nguyenv ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Here we keep around an old-style experiment to regress on our ability to upgrade its shapes.
For this PR we only test accessors on the data. On #3148 these unit test will be extended to check their upgrading of the old-style experiment.
Notes for Reviewer: