[python] Let registrar provide new shapes for resize#3152
Merged
Conversation
johnkerl
changed the title
johnkerl
changed the title
jp-dark
approved these changes
Oct 9, 2024
Collaborator
jp-dark
left a comment
jp-dark
left a comment
There was a problem hiding this comment.
It doesn't look like any tests were added for the get_*_shape == 0 case. Otherwise, looks good to me.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
For experiment-level resize and append mode (#3148) we'll need the registrar to offer up the new shapes that the experiment will need to be resized to. This PR supports that goal.
Notes for Reviewer:
This PR is a work in progress. It is not ready for review.