[c++] Add can-resize helpers in prep for experiment-level resize#3095
Merged
[c++] Add can-resize helpers in prep for experiment-level resize#3095
Conversation
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/cpp-exp-resize-prep
branch
2 times, most recently
from
c793bcd to
116f4e8
Compare
johnkerl
changed the base branch from
main
to
kerl/maybe-resize-soma-joinid-py-r
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3095 +/- ##
==========================================
+ Coverage 88.95% 89.09% +0.13%
==========================================
Files 45 45
Lines 4293 4293
==========================================
+ Hits 3819 3825 +6
+ Misses 474 468 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
reviewed
Sep 30, 2024
nguyenv
approved these changes
Sep 30, 2024
johnkerl
force-pushed
the
kerl/maybe-resize-soma-joinid-py-r
branch
3 times, most recently
from
e55735b to
2b4d5a0
Compare
johnkerl
force-pushed
the
kerl/cpp-exp-resize-prep
branch
from
116f4e8 to
3adcacf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Changes:
For experiment-level resize (e.g. append mode) it will be crucial that we implement a mechanism to detect whether all arrays in the experiment are resizable up to the new
(nobs, nvar)before attempting any resizes. In particular, it would be bad to succeed in resizing some member arrays and fail on one or more.Notes for Reviewer: