[c++] Simplify internal API for dataframe-resizer#3090
Merged
johnkerl merged 5 commits intokerl/sdf-domain-at-createfrom Sep 30, 2024
Merged
[c++] Simplify internal API for dataframe-resizer#3090johnkerl merged 5 commits intokerl/sdf-domain-at-createfrom
johnkerl merged 5 commits intokerl/sdf-domain-at-createfrom
Conversation
johnkerl
requested review from
XanthosXanthopoulos,
jp-dark and
nguyenv
and removed request for
jp-dark
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kerl/sdf-domain-at-create #3090 +/- ##
============================================================
Coverage ? 89.16%
============================================================
Files ? 45
Lines ? 4284
Branches ? 0
============================================================
Hits ? 3820
Misses ? 464
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/maybe-resize-soma-joinid-cpp-tweak
branch
from
89d98ef to
0178ab5
Compare
johnkerl
force-pushed
the
kerl/maybe-resize-soma-joinid-cpp-tweak
branch
from
0178ab5 to
7981d82
Compare
…rsion (#3086) * Update the encoding version to 1.1.0 * Update errors for valid soma types that are not yet implemented
nguyenv
approved these changes
Sep 30, 2024
johnkerl
force-pushed
the
kerl/maybe-resize-soma-joinid-cpp-tweak
branch
from
7981d82 to
96f70e1
Compare
Contributor
Author
|
Thanks @nguyenv ! |
johnkerl
force-pushed
the
kerl/maybe-resize-soma-joinid-cpp-tweak
branch
from
96f70e1 to
3258070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
While the full-generality
upgrade_domainis tasked out on #2407, the foremost use-case for append mode, andtests/testthat/test-write-soma-resume.Rfor PR #3089, will need a simpller keystroke-saver which is already implemented in C++.What this existing method does in C++ is resize the
soma_joiniddim, if it's a dim, and leave the other dims as-is; ifsoma_joinidis not a dim, leave it as-is. This exists in C++, it's unit-tested in C++, and it's ready (and it's time) to be plumbed up to Python and R as well.I realize now that having C++
maybe_resize_joinidtake a length-1 vector, and assert that it's length-1, is silly -- it should simply take a singleint64_t. This PR does just that. It also removes the confusing prefixmaybe_.Notes for Reviewer: