[python] Use same default max domain between Python and R#3088
Merged
Conversation
johnkerl
force-pushed
the
kerl/max-domain-int64
branch
from
c285f12 to
413e34d
Compare
johnkerl
force-pushed
the
kerl/max-domain-int64
branch
2 times, most recently
from
348d942 to
1561810
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
==========================================
+ Coverage 88.98% 89.12% +0.14%
==========================================
Files 45 45
Lines 4286 4287 +1
==========================================
+ Hits 3814 3821 +7
+ Misses 472 466 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/max-domain-int64
branch
from
1561810 to
c37530d
Compare
nguyenv
approved these changes
Sep 30, 2024
mojaveazure
approved these changes
Sep 30, 2024
Contributor
Author
|
Thanks @nguyenv and @mojaveazure ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
In Python we were trying to use default max shapes there were 31-bit friendly for R compatibility. However, in R we're already setting 63-bit maxdomain:
https://github.com/single-cell-data/TileDB-SOMA/blob/1.14.1/apis/r/R/utils-arrow.R#L127
Notes for Reviewer: