[python/r] Use pushdown domainish accessors at the Python/R UX level#3027
Merged
[python/r] Use pushdown domainish accessors at the Python/R UX level#3027
Conversation
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/hll-domainish
branch
from
1befcd5 to
1f8e674
Compare
johnkerl
force-pushed
the
kerl/hll-domainish
branch
5 times, most recently
from
47c1b25 to
8cbcf91
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kerl/cpp-sdf-domain-at-create #3027 +/- ##
================================================================
Coverage ? 49.62%
================================================================
Files ? 57
Lines ? 8890
Branches ? 819
================================================================
Hits ? 4412
Misses ? 4278
Partials ? 200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/hll-domainish
branch
8 times, most recently
from
0557481 to
ef401e1
Compare
johnkerl
force-pushed
the
kerl/hll-domainish
branch
from
ef401e1 to
f1c104a
Compare
mojaveazure
requested changes
Sep 25, 2024
johnkerl
force-pushed
the
kerl/hll-domainish
branch
from
331a662 to
74c5503
Compare
johnkerl
changed the base branch from
main
to
kerl/cpp-sdf-domain-at-create
johnkerl
force-pushed
the
kerl/cpp-sdf-domain-at-create
branch
from
9574fe7 to
e614221
Compare
johnkerl
force-pushed
the
kerl/hll-domainish
branch
from
74c5503 to
45e77bb
Compare
johnkerl
force-pushed
the
kerl/cpp-sdf-domain-at-create
branch
from
e614221 to
bcc51f3
Compare
johnkerl
force-pushed
the
kerl/hll-domainish
branch
2 times, most recently
from
b00406e to
a09f6bd
Compare
johnkerl
force-pushed
the
kerl/cpp-sdf-domain-at-create
branch
from
235e699 to
74c7f15
Compare
johnkerl
force-pushed
the
kerl/hll-domainish
branch
from
a09f6bd to
7cf09c0
Compare
mojaveazure
approved these changes
Sep 26, 2024
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
LGTM on the R-side; will defer to other for Python. Before merging, please bump the develop version and update the changelog
johnkerl
force-pushed
the
kerl/cpp-sdf-domain-at-create
branch
from
74c7f15 to
be66574
Compare
Co-authored-by: Paul Hoffman <[email protected]>
johnkerl
force-pushed
the
kerl/hll-domainish
branch
from
7cf09c0 to
f0504ea
Compare
nguyenv
approved these changes
Sep 27, 2024
johnkerl
force-pushed
the
kerl/cpp-sdf-domain-at-create
branch
from
be66574 to
a40f130
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
See also [sc-55659].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Following #3012 we can now connect tiledbsoma-py to use the full domainish accessors from
libtiledbsoma.Notes for Reviewer:
R mods to come on this same PR.
This PR is a work in progress. It is not ready for review.