[c++] Update dataframe unit-test writes in prep for polytype domainish accessors#3017
Merged
[c++] Update dataframe unit-test writes in prep for polytype domainish accessors#3017
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3017 +/- ##
===========================================
+ Coverage 61.10% 89.79% +28.69%
===========================================
Files 95 40 -55
Lines 12382 4096 -8286
Branches 781 0 -781
===========================================
- Hits 7566 3678 -3888
+ Misses 4625 418 -4207
+ Partials 191 0 -191
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Sep 19, 2024
This was referenced Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Split-out underneath #3012
Notes for Reviewer: