Conversation
eddelbuettel
previously requested changes
Sep 17, 2024
Contributor
eddelbuettel
left a comment
eddelbuettel
left a comment
There was a problem hiding this comment.
Please also remove the <= part in DESCRIPTION just keeping the more innocent >= for the relation to tiledb-r
mojaveazure
approved these changes
Sep 17, 2024
Member
mojaveazure
left a comment
mojaveazure
left a comment
There was a problem hiding this comment.
We can also get rid of the "Install tiledb-r" step of CI as that was necessary only for the doublepin. Now that that's gone, we can fall back on the regular install dependencies step
Contributor
|
@mojaveazure Maybe in a follow-up PR? |
Member
|
Yeah, that should be a follow-up, I was just making a note of what else can be done thanks to the relaxing of tiledb-r versions. The current CI is working, and that's good enough for now |
mojaveazure
added a commit
to TileDB-Inc/tiledb-inc.r-universe.dev
that referenced
this pull request
Oct 8, 2024
Now that tiledbsoma-r no longer has a maximal pin on tiledb-r single-cell-data/TileDB-SOMA#3006, switch to buidling the latest development version of tiledb-r (latest commit on `main`)
mojaveazure
added a commit
that referenced
this pull request
Nov 8, 2024
Remove specific installation steps for tiledb-r as the doublepin was removed in #3006 resolves #3314 [SC-59087](https://app.shortcut.com/tiledb-inc/story/59087)
mojaveazure
added a commit
that referenced
this pull request
Nov 8, 2024
Remove specific installation steps for tiledb-r as the doublepin was removed in #3006 resolves #3314 [SC-59087](https://app.shortcut.com/tiledb-inc/story/59087)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was very much put in place for a good reason at the time it was put in place. However, as of recently we no longer use the tiledb-r path to read or write arrays.