[python] Move temporary feature flag into a module#3005
Merged
Conversation
johnkerl
requested review from
jp-dark,
nguyenv,
ryan-williams and
thetorpedodog
johnkerl
force-pushed
the
kerl/feature-flag-module
branch
from
4b6e120 to
877b5da
Compare
This was referenced Sep 17, 2024
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
==========================================
+ Coverage 89.64% 89.79% +0.15%
==========================================
Files 39 40 +1
Lines 4094 4096 +2
==========================================
+ Hits 3670 3678 +8
+ Misses 424 418 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
thetorpedodog
approved these changes
Sep 17, 2024
Contributor
thetorpedodog
left a comment
thetorpedodog
left a comment
There was a problem hiding this comment.
the move is fine; I do have one suggestion for the implementation while you’re moving things that you can take or leave.
Contributor
Author
|
Thanks @thetorpedodog ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Follow-up from here: #3001 (comment)
Changes:
Notes for Reviewer: