Conversation
johnkerl
requested review from
ihnorton,
nguyenv,
teo-tsirpanis and
thetorpedodog
johnkerl
commented
Sep 17, 2024
| # This is important since we need to do the above dll/dylib/so business | ||
| # _before_ imports, but, ruff will tell us that imports need to be | ||
| # at the top of the file: | ||
| # |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
==========================================
+ Coverage 89.64% 89.78% +0.14%
==========================================
Files 39 39
Lines 4094 4094
==========================================
+ Hits 3670 3676 +6
+ Misses 424 418 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
teo-tsirpanis
approved these changes
Sep 17, 2024
Contributor
Author
|
@teo-tsirpanis has approved; not sure what happened to his approval but it's past EOD in his timezone |
Member
|
My approval does not count as a prerequisite for merging a PR because I don't have write permissions to this repository. |
Contributor
Author
|
Ah, thanks @teo-tsirpanis ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-awaited work coming to fruition:
mainbranch #2734See also #2999 [sc-53002]