Skip to content

[c++] Push polymorphic domain-ish accessors down to C++#2995

Closed
johnkerl wants to merge 1 commit intomainfrom
kerl/polydom
Closed

[c++] Push polymorphic domain-ish accessors down to C++#2995
johnkerl wants to merge 1 commit intomainfrom
kerl/polydom

Conversation

@johnkerl
Copy link
Copy Markdown
Contributor

@johnkerl johnkerl commented Sep 13, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Changes:

Please see the description of #2994. This leverages 2994 to begin pushdown to libtiledbsoma.

Note this PR will only introduce the pushed-down logic within libtiledbsoma. R and Python PRs will be atop this.

Notes for Reviewer:

This PR is a work in progress. It is not ready for review.

  • This needs a code-reuse hook for domain, current domain, and non-empty domain
  • It needs unit tests

@johnkerl johnkerl marked this pull request as draft September 13, 2024 22:05
@johnkerl johnkerl changed the title [c++] Push full domain, current_domain, and non_empty_domain down to libtiledbsoma [c++] Push polymorphic domain-ish accessors down to libtiledbsoma Sep 13, 2024
@johnkerl johnkerl changed the title [c++] Push polymorphic domain-ish accessors down to libtiledbsoma [c++] Push polymorphic domain-ish accessors down to C++ Sep 13, 2024
@johnkerl johnkerl marked this pull request as ready for review September 13, 2024 22:33
@johnkerl johnkerl marked this pull request as draft September 13, 2024 22:33
@johnkerl johnkerl force-pushed the kerl/polydom branch 6 times, most recently from 0a116d9 to 678c6dc Compare September 16, 2024 00:11
Base automatically changed from kerl/nanoarrow-helpers to main September 16, 2024 19:35
@johnkerl johnkerl force-pushed the kerl/polydom branch 2 times, most recently from 9b21cfc to 7c115a4 Compare September 16, 2024 23:19
@johnkerl
Copy link
Copy Markdown
Contributor Author

This has successfully been split out into #2997 #3011 #3017 #3018 #3012

@johnkerl johnkerl closed this Sep 19, 2024
@johnkerl johnkerl deleted the kerl/polydom branch November 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant