[c++] Centralize some nanoarrow helpers#2994
Merged
Conversation
a4f230e to
eb019b5
Compare
eb019b5 to
2cf3790
Compare
nanoarrow helpers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2994 +/- ##
===========================================
- Coverage 89.64% 61.15% -28.50%
===========================================
Files 39 94 +55
Lines 4096 12378 +8282
Branches 0 781 +781
===========================================
+ Hits 3672 7570 +3898
- Misses 424 4617 +4193
- Partials 0 191 +191
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Sep 13, 2024
nanoarrow helpersnanoarrow helpers [WIP]
nanoarrow helpers [WIP]nanoarrow helpers
c9c4a87 to
800479d
Compare
nguyenv
approved these changes
Sep 16, 2024
Contributor
Author
|
Thanks @nguyenv ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Changes:
Extracting readback of core domain, current domain, and non-empty domain are all currently:
libtiledbsoma, templatized;pybind11layer lke thisTileDB-SOMA/apis/python/src/tiledbsoma/soma_array.cc
Lines 671 to 830 in b3feada
The best option for Python/R interop is:
libtiledbsomananoarrowto interface with Python and RThe current PR simply moves some code currently used in
libtiledbsoma's unit-test logic toArrowAdapter, where it can -- and will -- be used for readback of core domain, current domain, and non-empty domain for #2407.Notes for Reviewer:
This is just a code-move. If all existing unit tests pass, that is success. No new unit tests are introduced here, since no new unit tests are needed.