[c++] Fix bug in nnz of variant-indexed dataframes#2990
Merged
Conversation
Contributor
Author
|
Leaving in draft while I address a unit-test failure |
johnkerl
force-pushed
the
kerl/variant-nnz-bug
branch
from
a4a76e4 to
a26e90d
Compare
johnkerl
force-pushed
the
kerl/variant-nnz-bug
branch
from
a26e90d to
265c9b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
==========================================
+ Coverage 89.64% 89.79% +0.14%
==========================================
Files 40 40
Lines 4096 4096
==========================================
+ Hits 3672 3678 +6
+ Misses 424 418 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jp-dark
reviewed
Sep 20, 2024
jp-dark
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Pre-existing bug found while working on issue #2407 / [sc-51048].
I ran
sdf.count()on a variant-indexed dataframe which has dim0 being a string (which the spec allows even though most users don't take advantage of this). I got the errorThere is a repro now built into the unit-test cases on this PR.
Changes:
Only use the code that assumes dim0 is
int64soma_joinidwhen that is in fact the case.Notes for Reviewer: