[c++/python] More exception-mapping fixes#2980
Merged
Conversation
johnkerl
force-pushed
the
kerl/more-exception-mapping
branch
from
82ca4f0 to
5b08e4d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2980 +/- ##
==========================================
+ Coverage 89.84% 89.87% +0.03%
==========================================
Files 39 39
Lines 4057 4080 +23
==========================================
+ Hits 3645 3667 +22
- Misses 412 413 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: [sc-54978]
Changes:
pybind11exception-mapping #2963. I missed a couple spots.RuntimeErroron @bkmartinjr 's [c++] Refine concurrency configuration (soma.compute_concurrency_level) #2978. (I applied this PR on top of 2978 in my Mac sandbox & observed no moreRuntimeError.)TileDBSOMAPyErroris redundant withTileDBSOMAError(multiple-author syndrome I suspect) -- the two serve identical roles and are coalesced on this PR.Notes for Reviewer: