[python] Minor name-neaten in internals for domain/maxdomain#2969
Merged
[python] Minor name-neaten in internals for domain/maxdomain#2969
domain/maxdomain#2969Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2969 +/- ##
==========================================
+ Coverage 89.84% 89.99% +0.14%
==========================================
Files 39 39
Lines 4057 4057
==========================================
+ Hits 3645 3651 +6
+ Misses 412 406 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/more-py-domain-name-neaten
branch
from
51cfb8d to
d4865fa
Compare
johnkerl
force-pushed
the
kerl/more-py-domain-name-neaten
branch
from
d4865fa to
9eb7de7
Compare
nguyenv
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Changes:
This is a minor deconfuse as I was trying to understand
SOMADataFrame'sdomainandmaxdomainon the Python side in prep to port them to R.Notes for Reviewer:
This is follow-on to #2957: this is a spot I missed there, and should (ideally) have done on that PR.