[python/r] Array-creation mods for new shape#2962
Merged
Conversation
johnkerl
force-pushed
the
kerl/py-r-creation-paths
branch
5 times, most recently
from
db85fe5 to
5f18361
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2962 +/- ##
==========================================
+ Coverage 89.84% 89.87% +0.03%
==========================================
Files 39 39
Lines 4057 4080 +23
==========================================
+ Hits 3645 3667 +22
- Misses 412 413 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/py-r-creation-paths
branch
from
5f18361 to
81466f6
Compare
Contributor
Author
|
Back in draft while I fix CI |
johnkerl
force-pushed
the
kerl/py-r-creation-paths
branch
from
d4d8394 to
0b5bddb
Compare
johnkerl
force-pushed
the
kerl/py-r-creation-paths
branch
from
0b5bddb to
192b63f
Compare
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/py-r-creation-paths
branch
4 times, most recently
from
24026da to
0d0c314
Compare
nguyenv
reviewed
Sep 9, 2024
johnkerl
force-pushed
the
kerl/py-r-creation-paths
branch
from
0d0c314 to
4c873f3
Compare
Contributor
Author
|
@nguyenv ready for re-review |
nguyenv
approved these changes
Sep 11, 2024
Contributor
nguyenv
left a comment
nguyenv
left a comment
There was a problem hiding this comment.
Looks good on the Python side.
Contributor
Author
|
@mojaveazure ping 🙏 |
johnkerl
force-pushed
the
kerl/py-r-creation-paths
branch
from
58c3ec9 to
a5b58ce
Compare
mojaveazure
requested changes
Sep 11, 2024
johnkerl
force-pushed
the
kerl/py-r-creation-paths
branch
from
54bb1d5 to
c7e064a
Compare
Contributor
Author
|
@mojaveazure I think I've got all your points addressed! :) |
mojaveazure
approved these changes
Sep 11, 2024
Contributor
Author
|
Thanks @nguyenv and @mojaveazure ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
shapefor component arrays #2407shapefor component arrays #2407Notes for Reviewer: