[python/r] Expose shape-related accessors to Python/R bindings#2953
Merged
[python/r] Expose shape-related accessors to Python/R bindings#2953
Conversation
johnkerl
force-pushed
the
kerl/py-r-accessor-plumbing
branch
from
ba528ba to
021ed67
Compare
nguyenv
reviewed
Sep 4, 2024
johnkerl
force-pushed
the
kerl/py-r-accessor-plumbing
branch
from
6cbe435 to
6dba46b
Compare
johnkerl
requested review from
nguyenv
and removed request for
mojaveazure and
nguyenv
johnkerl
force-pushed
the
kerl/py-r-accessor-plumbing
branch
from
6dba46b to
8ef6cf4
Compare
johnkerl
force-pushed
the
kerl/py-r-accessor-plumbing
branch
4 times, most recently
from
195240b to
2a9f119
Compare
johnkerl
force-pushed
the
kerl/py-r-accessor-plumbing
branch
2 times, most recently
from
448dd7a to
06aac21
Compare
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/py-r-accessor-plumbing
branch
2 times, most recently
from
6e2b8ce to
5c09c72
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2953 +/- ##
===========================================
- Coverage 89.87% 61.31% -28.57%
===========================================
Files 38 93 +55
Lines 3999 12417 +8418
Branches 0 781 +781
===========================================
+ Hits 3594 7613 +4019
- Misses 405 4606 +4201
- Partials 0 198 +198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/py-r-accessor-plumbing
branch
from
5c09c72 to
465e9a1
Compare
nguyenv
approved these changes
Sep 5, 2024
Contributor
nguyenv
left a comment
nguyenv
left a comment
There was a problem hiding this comment.
Looks good for the Python side.
Contributor
Author
|
@mojaveazure can you please take a look at the R side? Thank you! |
mojaveazure
previously requested changes
Sep 5, 2024
johnkerl
force-pushed
the
kerl/py-r-accessor-plumbing
branch
from
bac2027 to
5312d49
Compare
mojaveazure
approved these changes
Sep 5, 2024
Contributor
Author
|
Thanks @nguyenv and @mojaveazure ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
shapefor component arrays #2407_maybe_sjid_shapeand_maybe_sjid_maxshapeaccessors will be crucial for experiment-level resize logic as on append mode, which does not yet exist in TileDB-SOMA-R (see [r] Port append-mode logic #1630)Notes for Reviewer: