Skip to content

[python/r] Temporary feature-flags for stacked PRs [WIP]#2952

Closed
johnkerl wants to merge 1 commit intomainfrom
kerl/feature-flag-temp
Closed

[python/r] Temporary feature-flags for stacked PRs [WIP]#2952
johnkerl wants to merge 1 commit intomainfrom
kerl/feature-flag-temp

Conversation

@johnkerl
Copy link
Copy Markdown
Contributor

@johnkerl johnkerl commented Sep 4, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Changes:

This is a temporary feature-flag setup to enable iterative testing of current-domain features over multiple PRs in a stack.

Notes for Reviewer:

Not ready for review or merge at this time. In particular, the contents of this PR are not intended to survive to a tagged release of TileDB-SOMA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.75%. Comparing base (7983df0) to head (3e66b92).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2952      +/-   ##
==========================================
- Coverage   89.87%   89.75%   -0.13%     
==========================================
  Files          38       38              
  Lines        3999     4020      +21     
==========================================
+ Hits         3594     3608      +14     
- Misses        405      412       +7     
Flag Coverage Δ
python 89.75% <66.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.75% <66.66%> (-0.13%) ⬇️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl force-pushed the kerl/feature-flag-temp branch 4 times, most recently from 4371b2c to 8054c4d Compare September 4, 2024 23:41
@johnkerl johnkerl changed the base branch from main to kerl/py-r-accessor-plumbing September 4, 2024 23:43
@johnkerl johnkerl changed the title [python/r] Temporary feature-flags for stacked PRs [WIP] [python/r] Temporary feature-flags for stacked PRs [no merge] Sep 5, 2024
@johnkerl johnkerl changed the title [python/r] Temporary feature-flags for stacked PRs [no merge] [python/r] Temporary feature-flags for stacked PRs [WIP] Sep 5, 2024
@johnkerl johnkerl force-pushed the kerl/py-r-accessor-plumbing branch from 6e2b8ce to 5c09c72 Compare September 5, 2024 13:36
@johnkerl johnkerl force-pushed the kerl/feature-flag-temp branch 2 times, most recently from e57cd9f to 2cce8fa Compare September 5, 2024 13:48
@johnkerl johnkerl force-pushed the kerl/py-r-accessor-plumbing branch from 5c09c72 to 465e9a1 Compare September 5, 2024 16:32
@johnkerl johnkerl force-pushed the kerl/feature-flag-temp branch 2 times, most recently from 7642bb5 to 0f1352f Compare September 5, 2024 19:45
@johnkerl johnkerl changed the base branch from kerl/py-r-accessor-plumbing to kerl/sdf-domain-accessors September 5, 2024 19:46
@johnkerl johnkerl force-pushed the kerl/sdf-domain-accessors branch from 1ca54fd to a671495 Compare September 5, 2024 20:01
@johnkerl johnkerl force-pushed the kerl/feature-flag-temp branch from 0f1352f to 5eeea90 Compare September 5, 2024 20:02
@johnkerl johnkerl force-pushed the kerl/sdf-domain-accessors branch from a671495 to d142e2d Compare September 5, 2024 21:42
@johnkerl johnkerl force-pushed the kerl/feature-flag-temp branch from 5eeea90 to 7675dce Compare September 5, 2024 21:43
@johnkerl johnkerl force-pushed the kerl/sdf-domain-accessors branch from d142e2d to 8a2a9f6 Compare September 6, 2024 14:27
@johnkerl johnkerl force-pushed the kerl/feature-flag-temp branch from 7675dce to aeb5141 Compare September 6, 2024 14:27
Base automatically changed from kerl/sdf-domain-accessors to main September 6, 2024 18:45
@johnkerl johnkerl force-pushed the kerl/feature-flag-temp branch from aeb5141 to 8a883be Compare September 6, 2024 20:48
@johnkerl
Copy link
Copy Markdown
Contributor Author

johnkerl commented Sep 6, 2024

This has been folded into #2962.

@johnkerl johnkerl closed this Sep 6, 2024
@johnkerl johnkerl deleted the kerl/feature-flag-temp branch November 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant