[c++] Clarify dataframe-shaping test/access points#2951
Merged
Conversation
johnkerl
force-pushed
the
kerl/sdf-test-accessors
branch
from
5c03e17 to
a40cf77
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2951 +/- ##
==========================================
+ Coverage 89.87% 90.02% +0.15%
==========================================
Files 38 38
Lines 3999 3999
==========================================
+ Hits 3594 3600 +6
+ Misses 405 399 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/sdf-test-accessors
branch
from
a40cf77 to
9ee2797
Compare
johnkerl
force-pushed
the
kerl/sdf-test-accessors
branch
from
9ee2797 to
ee19025
Compare
nguyenv
approved these changes
Sep 4, 2024
johnkerl
force-pushed
the
kerl/sdf-test-accessors
branch
from
1dddbeb to
0025ed7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: This is iterative progress for issue #2407 / [sc-51048].
The intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
While iterating at the application level (#2950) I realized I'd needlessly confused myself with the accessors to get a dataframe's shape/maxshape along the
soma_joiniddimension (if it has one).These clarify the picture.
Notes for Reviewer:
In this PR these methods are unit-tested against their stated semantics. They'll get put to work in a PR split out from #2950.