[c++] Unit-test resize for SparseNDArray and DenseNDArray#2947
Merged
Conversation
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/cpp-ndarray-resize-testing
branch
from
b99d86f to
24dc00e
Compare
johnkerl
changed the title
resize for SparseNDArray and DenseNDArray
nguyenv
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: This follows on #2945 for issue #2407 / [sc-51048]. Here we implement
resize.Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Given the improved fixturing for
libtiledbsoma, it's now a short hop to implement unit-test coverage forresizein these two classes.Notes for Reviewer: