[c++] Unit-test variant-indexed dataframes#2944
Merged
Conversation
johnkerl
force-pushed
the
kerl/cpp-variant-indexed-dataframes
branch
from
cc30a6b to
4ab9096
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2944 +/- ##
==========================================
+ Coverage 89.87% 90.02% +0.15%
==========================================
Files 38 38
Lines 3999 3999
==========================================
+ Hits 3594 3600 +6
+ Misses 405 399 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/cpp-variant-indexed-dataframes
branch
2 times, most recently
from
6bf9cf8 to
2b76537
Compare
johnkerl
force-pushed
the
kerl/cpp-variant-indexed-dataframes
branch
from
2b76537 to
fc2e789
Compare
johnkerl
force-pushed
the
kerl/cpp-variant-indexed-dataframes
branch
2 times, most recently
from
db6e299 to
f855054
Compare
johnkerl
force-pushed
the
kerl/dataframe-test-fixture
branch
from
8724a85 to
1bb4f69
Compare
johnkerl
force-pushed
the
kerl/cpp-variant-indexed-dataframes
branch
from
f855054 to
b9c5c3c
Compare
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/cpp-variant-indexed-dataframes
branch
from
b9c5c3c to
2389b53
Compare
johnkerl
force-pushed
the
kerl/cpp-variant-indexed-dataframes
branch
from
520f37c to
db93171
Compare
nguyenv
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: This is iterative progress for issue #2407 / [sc-51048].
The intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Leverages #2939 and #2945 to unit-test variant-indexed soma dataframes at the
libtiledbsomalevel.No shape-accessor logic is checked on this PR: see #2916.
No resize logic is checked on this PR: see #2917.
Notes for Reviewer: