[c++] Parameterize schema-creation unit-test helpers#2939
Merged
Conversation
johnkerl
force-pushed
the
kerl/step-two-temp
branch
from
67f5b66 to
5947c98
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2939 +/- ##
==========================================
+ Coverage 89.87% 90.02% +0.15%
==========================================
Files 38 38
Lines 3999 3999
==========================================
+ Hits 3594 3600 +6
+ Misses 405 399 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/step-two-temp
branch
2 times, most recently
from
c50b714 to
4889f93
Compare
johnkerl
changed the title
Contributor
Author
|
Leaving this in draft until I address unit-test failures |
johnkerl
force-pushed
the
kerl/step-two-temp
branch
3 times, most recently
from
fdfb585 to
b43f5f7
Compare
johnkerl
force-pushed
the
kerl/step-two-temp
branch
2 times, most recently
from
14fd597 to
d7be17a
Compare
johnkerl
force-pushed
the
kerl/step-two-temp
branch
from
d7be17a to
79f8d09
Compare
nguyenv
approved these changes
Aug 30, 2024
Contributor
nguyenv
left a comment
nguyenv
left a comment
There was a problem hiding this comment.
lgtm. Comments are just informational.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: This is a line-count-reducing under-diff following on #2936 for issue #2407 / [sc-51048].
The intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Some prep for having variant-indexed dataframe objects in libtiledbsoma test so that #2916 and #2917 can be unit-tested.
This will get put to work for other datatypes on #2916 and #2917.
Notes for Reviewer:
#2785 is unreviewable as-is: besides being a WIP, it's an all-in-one experimental area. Smaller PRs such as this one are being offered for manageable review.