[c++] Minor function-extract in a unit-test helper#2919
Merged
Conversation
johnkerl
changed the title
nguyenv
approved these changes
Aug 27, 2024
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
976c398 to
86f1ce3
Compare
johnkerl
force-pushed
the
kerl/minor-unit-test-helper-mod
branch
2 times, most recently
from
9cd956f to
01bd669
Compare
Contributor
Author
|
Rebased onto fresh |
johnkerl
force-pushed
the
kerl/minor-unit-test-helper-mod
branch
from
01bd669 to
fd9d7cf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
==========================================
+ Coverage 89.87% 90.02% +0.15%
==========================================
Files 38 38
Lines 3999 3999
==========================================
+ Hits 3594 3600 +6
+ Misses 405 399 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
The intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
This is not strictly necessary -- all is does is remove some code duplication, which is a cosmetic nice-to-have. However, I found it helpful fo help me understand the functions in
libtiledbsoma/test/common.cc, since I'll need to add to it.Specifcally:
SparseNDArrayandDenseNDArrayare always indexed byint64SOMADataFrameis indexed by default with a singleint64soma_joinidint64soma_joinid-- or, they can have one or more dims whilesoma_joinidis merely an attr, not a dim at all.That third bullet has been unit-tested in TileDB-SOMA-Py for some time now; it hasn't been unit-tested in
libtiledbsomaat all. For the changes on #2407 I'd like to rectify that, to increase confidence in PRs such as #2917.Notes for Reviewer:
Currently this is stacked atop
kerl/cpp-resizeswhich is PR #2917. If this PR can be approved sooner than some of the other ones on #2407 (and I believe it should be) then I will rebase this on top of currentmainin an attempt to unstack it from #2917.