Merged
Conversation
johnkerl
requested review from
jp-dark,
mojaveazure,
nguyenv and
ryan-williams
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
==========================================
+ Coverage 89.88% 90.03% +0.15%
==========================================
Files 37 37
Lines 3925 3925
==========================================
+ Hits 3528 3534 +6
+ Misses 397 391 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
ryan-williams
approved these changes
Aug 19, 2024
jp-dark
approved these changes
Aug 19, 2024
johnkerl
force-pushed
the
kerl/cpp-test-deadstrip
branch
from
8d1db6b to
5123550
Compare
johnkerl
force-pushed
the
kerl/cpp-test-deadstrip
branch
from
5123550 to
ebd3a06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Found while working on issue #2407 / [sc-51048].
Changes: The three places
create_schemais called, it is not used.Notes for Reviewer: