[c++] Resize for variant-indexed DataFrame#2917
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
==========================================
+ Coverage 89.87% 90.02% +0.15%
==========================================
Files 38 38
Lines 3999 3999
==========================================
+ Hits 3594 3600 +6
+ Misses 405 399 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
6db6134 to
21155f6
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
3 times, most recently
from
b915255 to
e7e8cc2
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
21155f6 to
696ab50
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
3 times, most recently
from
5d38f9f to
8a949db
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
8a949db to
361e2bc
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
2 times, most recently
from
0cd5ce5 to
0831bdb
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
361e2bc to
3a93b65
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
0831bdb to
8c5b2af
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
2 times, most recently
from
10d1add to
976c398
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
b56d07a to
651ee8a
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
976c398 to
86f1ce3
Compare
This was referenced Aug 28, 2024
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
651ee8a to
c875bff
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
86f1ce3 to
fa120ef
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
c875bff to
68d9d3e
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
fa120ef to
1bf7b10
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
3 times, most recently
from
982b541 to
2f01e04
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
1bf7b10 to
cfcc1e0
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
2f01e04 to
63efc44
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
4 times, most recently
from
ba690fb to
0ffd904
Compare
johnkerl
changed the title
DataFrame [WIP]DataFrame
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
3 times, most recently
from
046fdbf to
d27a748
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
d27a748 to
f55fd5e
Compare
nguyenv
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: This follows on #2917 for issue #2407 / [sc-51048]. Here we implement
resize.Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
While
SOMASparseNDArrayandSOMADenseNDArraymust always and only haveint64dims within the SOMA data model,SOMADataFrameis different. The default behavior -- which almost everyone uses -- has a singlesoma_joiniddim which is indeed of typeint64. (Also note thatexp.obs.shapedoes exist within TileDB-SOMA-Py, and people do call it.) However, the spec only requires thatsoma_joinidexist as a dim or an attr: it can be a dim along with others, or it can not be a dim at all. Here we do the right thing, without and with current-domain support, to allow people to resize thesoma_joiniddim, and only that, whether it's the sole dimension, a dimension but not the sole one, or not a dim at all.Notes for Reviewer: