Skip to content

[c++] Trivial name-neaten#2913

Merged
johnkerl merged 1 commit intomainfrom
kerl/name-neaten
Aug 19, 2024
Merged

[c++] Trivial name-neaten#2913
johnkerl merged 1 commit intomainfrom
kerl/name-neaten

Conversation

@johnkerl
Copy link
Copy Markdown
Contributor

Issue and/or context: Found while working on #2785 for issue #2407 / [sc-51048].

Changes: Use the named constant, like other places within this file.

Notes for Reviewer:

@johnkerl johnkerl requested review from jp-dark and nguyenv August 17, 2024 18:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.51%. Comparing base (bdba3c3) to head (eaaac90).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2913       +/-   ##
===========================================
- Coverage   89.88%   59.51%   -30.38%     
===========================================
  Files          37       92       +55     
  Lines        3925    11335     +7410     
  Branches        0      724      +724     
===========================================
+ Hits         3528     6746     +3218     
- Misses        397     4418     +4021     
- Partials        0      171      +171     
Flag Coverage Δ
libtiledbsoma 43.34% <100.00%> (?)
python 90.03% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.03% <ø> (+0.15%) ⬆️
libtiledbsoma 49.96% <100.00%> (∅)

@johnkerl johnkerl merged commit 4bb4972 into main Aug 19, 2024
@johnkerl johnkerl deleted the kerl/name-neaten branch August 19, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants