[c++] Trivial parameterizes in test/common.cc#2910
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2910 +/- ##
==========================================
+ Coverage 89.88% 90.03% +0.15%
==========================================
Files 37 37
Lines 3925 3925
==========================================
+ Hits 3528 3534 +6
+ Misses 397 391 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
test/common.cctest/common.cc
This was referenced Aug 18, 2024
jp-dark
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Changes:
Up until now the number of rows in arrow-schema/arrow-data for dataframe setup from Python/R to C++ has had 3 slots. On #2785 it will necessarily have 5. This PR parameterizes some hard-coded values of
3to now referencen, afterint n = 3.Similarly, this PR replaces a hard-coded within-function 1000 to a new parameter
dim_maxfor use by callers, who will need explicit construction access to test resize logic for upcoming PRs on #2407.Notes for Reviewer: