[c++] Methodize timestamped-schema-evolution factory#2909
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
===========================================
- Coverage 89.88% 59.52% -30.37%
===========================================
Files 37 92 +55
Lines 3925 11337 +7412
Branches 0 724 +724
===========================================
+ Hits 3528 6748 +3220
- Misses 397 4418 +4021
- Partials 0 171 +171
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/schevo-timestamp-methodize
branch
from
156f817 to
4a16241
Compare
This was referenced Aug 17, 2024
jp-dark
approved these changes
Aug 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: This is a line-count-reducing under-diff split out from #2785 for issue #2407; [sc-51048].
Changes:
On #2895 I made an inline code block for instantiating an
ArraySchemaEvolutionobject pointed at the current array's context and open-at timestamp (if any). That was after I did a call-graph analysis that showed that this was the sole spot inmain-- at that point in time -- where we needed to do this.However, on #2785 we'll be making more use of schema evolution, from more than one callsite. It makes even more sense now to encapsulate this logic in a single place.
Notes for Reviewer: