[r,c++] Support DenseNDArray write case#2730
Merged
eddelbuettel merged 3 commits intomainfrom Jun 20, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
- Coverage 89.91% 89.32% -0.60%
==========================================
Files 37 37
Lines 4026 4037 +11
==========================================
- Hits 3620 3606 -14
- Misses 406 431 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
Marked as draft as some of the sparse cases blow up. |
eddelbuettel
force-pushed
the
de/sc-44887/dense_nd_write
branch
from
a64dd2f to
8369cf4
Compare
Contributor
Author
|
I have now spent days debugging this, and it tends to pass on why machine but continues to bonk on Linux at CI. |
Contributor
Author
|
And then just re-running it makes it green 🤷♂️ @nguyenv @mojaveazure please review at your convenience |
mojaveazure
approved these changes
Jun 20, 2024
johnkerl
changed the title
DenseNDArray write case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
This PR extends the C++-fication to dense n-dimensional array.
Changes:
Refactored code to use C++ classes to write.
Notes for Reviewer:
SC 44887