[Backport release-1.7] Backport #2158 and #2166 to release-1.7#2170
Merged
johnkerl merged 1 commit intorelease-1.7from Feb 23, 2024
Merged
[Backport release-1.7] Backport #2158 and #2166 to release-1.7#2170johnkerl merged 1 commit intorelease-1.7from
release-1.7#2170johnkerl merged 1 commit intorelease-1.7from
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.7 #2170 +/- ##
===============================================
- Coverage 78.38% 72.08% -6.30%
===============================================
Files 135 102 -33
Lines 10699 6885 -3814
Branches 211 215 +4
===============================================
- Hits 8386 4963 -3423
+ Misses 2211 1823 -388
+ Partials 102 99 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #2158 and #2166 to the
release-1.7branch. As with #2165, I had hoped for a clean backport, but I found on #2158 that that sadly did not occur. Instead, I am re-iterating the approach of #2165, which is a bulk-sync ofmaintorelease-1.7except for these release-specific files: