[python] Use bindings for DenseNDArray readpath#2132
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2132 +/- ##
==========================================
- Coverage 78.63% 71.99% -6.65%
==========================================
Files 136 102 -34
Lines 10653 6880 -3773
Branches 215 215
==========================================
- Hits 8377 4953 -3424
+ Misses 2177 1827 -350
- Partials 99 100 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Feb 13, 2024
Base automatically changed from
viviannguyen/add-pybind11-ndarray-bindings
to
main
February 15, 2024 19:15
Contributor
Author
|
Needs to be updated to use |
nguyenv
force-pushed
the
viviannguyen/use-bindings-for-dense-ndarray
branch
from
229e297 to
a185f8a
Compare
johnkerl
reviewed
Feb 23, 2024
johnkerl
approved these changes
Feb 23, 2024
added 6 commits
February 23, 2024 15:48
nguyenv
force-pushed
the
viviannguyen/use-bindings-for-dense-ndarray
branch
from
d0a2f6c to
7185a5e
Compare
nguyenv
force-pushed
the
viviannguyen/use-bindings-for-dense-ndarray
branch
from
ca77ace to
614d886
Compare
thetorpedodog
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#2078
Changes:
Use
clib.DenseNDArrayfor read path, replacing usage oftiledb.Array.These changes were picked out of #1817.
Notes for Reviewer:
These changes are on top of #2129.