Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2129 +/- ##
==========================================
- Coverage 82.10% 78.67% -3.44%
==========================================
Files 87 136 +49
Lines 8112 10722 +2610
Branches 0 211 +211
==========================================
+ Hits 6660 8435 +1775
- Misses 1452 2185 +733
- Partials 0 102 +102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Base automatically changed from
viviannguyen/refactor-pybind11-inheritance
to
main
February 12, 2024 21:42
nguyenv
force-pushed
the
viviannguyen/add-pybind11-ndarray-bindings
branch
from
5b1a40b to
5fe06d0
Compare
This was referenced Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#2128
Changes:
Addition of
soma_dense_ndarray.ccandsoma_sparse.ndarray.cc.These changes were picked out of #1817.
Notes for Reviewer:
These changes are on top of #2126.