[c++] Support reading SOMAObject metadata in read and write mode#1584
Merged
[c++] Support reading SOMAObject metadata in read and write mode#1584
SOMAObject metadata in read and write mode#1584Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
===========================================
- Coverage 65.56% 54.22% -11.35%
===========================================
Files 109 75 -34
Lines 9221 6324 -2897
===========================================
- Hits 6046 3429 -2617
+ Misses 3175 2895 -280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Metadata getters available in read and write mode * Add metadata functions for `SOMAObject`s * `get_metadata` checks if key exists and returns `std::nullopt` if DNE
nguyenv
force-pushed
the
viviannguyen/access-metadata-any-mode
branch
from
e241405 to
5455352
Compare
nguyenv
changed the title
SOMAMetadataMappingSOMAMetadataMapping
nguyenv
requested review from
Shelnutt2,
bekadavis9,
beroy,
eddelbuettel,
gspowley,
johnkerl and
teo-tsirpanis
nguyenv
changed the title
SOMAMetadataMappingSOMAObject metadata to be accessible in read and write mode
nguyenv
changed the title
SOMAObject metadata to be accessible in read and write modeSOMAObject metadata in read and write mode
nguyenv
pushed a commit
that referenced
this pull request
Aug 24, 2023
* Follow up PR for #1584 (comment) * `SOMAObject` is meant to be a pure virtual class so all methods should be virtual * Update documentation for `get_metadata`
nguyenv
pushed a commit
that referenced
this pull request
Aug 24, 2023
* Follow up PR for #1584 (comment) * `SOMAObject` is meant to be a pure virtual class so all methods should be virtual * Update documentation for `get_metadata`
nguyenv
pushed a commit
that referenced
this pull request
Aug 24, 2023
* Follow up PR for #1584 (comment) * `SOMAObject` is meant to be a pure virtual class so all methods should be virtual * Update documentation for `get_metadata`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
SOMAObjects need metadata accessible in both read and write mode #1577Changes:
SOMAArrayorSOMAGroupis already open in read mode, fill the cache by usingmetadata_numandget_metadata_from_index. If it is open in write, open a temp handle in read mode to fill the metadata mapping and then close the temp handle.SOMAObjectsget_metadatachecks if key exists and returnsstd::nulloptif DNENotes for Reviewer:
N/A