You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Glitch: while with 3129 we are removing the last references to self$object within R/*.R, there are hundreds of lines of uses of $object within tests/testthat -- tracked on [r] Remove TileDB-R accesses within tests/testthat #3124
Then set a libtiledbsoma handle on construction/open, and close it on close
Modify all the methods to not take uri+ctx but rather the open handle
To check:
Currently the array set_metadata does not error out when the array is opened for read -- this is a bug.
This should be auto-fixed by this issue, but, it needs to be tested.
Currently we're retaining a tiledb-r handle at open:
TileDB-SOMA/apis/r/R/TileDBArray.R
Line 31 in 11d5396
And we use a temporary open-use-close at every single call to libtiledbsoma -- here is just one of many examples:
TileDB-SOMA/apis/r/src/metadata.cpp
Lines 170 to 193 in 11d5396
On the one hand this might seem lower-pri: the redundant opens are a perf hit but they work.
But as discussed on #3060 we must do this in order to remove the tiledb-r dependency.
See also #3053 which @nguyenv is working on -- this is a case where we do currently require a second open for array reads.
From #3059:
Already done for groups
#2406; [sc-55685].
Steps:
private$.tiledb_arraywith connection toself$objectlibtiledbsomahandles are currently ephemeralread/write/get_metadataetc which islibtiledbsoma-capable currently takes auriand actxand does open/op/closeprivate$.tiledb_arraywith connection toself$objectprivate$.tiledb_arrayandself$objectfrom R classes [WIP] #3129self$objectwithinR/*.R, there are hundreds of lines of uses of$objectwithintests/testthat-- tracked on [r] Remove TileDB-R accesses withintests/testthat#3124libtiledbsomahandle on construction/open, and close it on closeuri+ctxbut rather the open handleTo check:
set_metadatadoes not error out when the array is opened for read -- this is a bug.