Skip to content

[r] SOMADataFrame create needs to accept a domain argument #2967

@johnkerl

Description

@johnkerl

Found while working on issue #2407 / [sc-51048]. See also [sc-55657].

Python

The SOMADataFrame create method accepts domain here:

  • domain: Optional[Domain] = None,
  • domain:
    An optional sequence of tuples specifying the domain of each
    index column. Each tuple should be a pair consisting of the minimum and
    maximum values storable in the index column. For example, if there is a
    single int64-valued index column, then ``domain`` might be ``[(100,
    200)]`` to indicate that values between 100 and 200, inclusive, can be
    stored in that column. If provided, this sequence must have the same
    length as ``index_column_names``, and the index-column domain will be as
    specified. If omitted entirely, or if ``None`` in a given dimension,
    the corresponding index-column domain will use the minimum and maximum
    possible values for the column's datatype. This makes a
    :class:`DataFrame` growable.

R

The SOMADataFrame create method does not accept domain here:

For this reason, here

dom_ext_tbl <- get_domain_and_extent_dataframe(
schema,
ind_col_names = index_column_names,
tdco = tiledb_create_options
)

calling here
ind_dom <- arrow_type_unsigned_range(ind_col_type) - c(0,1) ## FIXME

the domain is taken from the datatype's max range.

This is a R/Python parity issue which will become noticeable on #2407 and should be prioritized.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions