Skip to content

Update docstrings for new-shape feature#250

Merged
johnkerl merged 3 commits intomainfrom
kerl/new-shape-docstrings
Dec 4, 2024
Merged

Update docstrings for new-shape feature#250
johnkerl merged 3 commits intomainfrom
kerl/new-shape-docstrings

Conversation

@johnkerl
Copy link
Copy Markdown
Contributor

@johnkerl johnkerl commented Dec 4, 2024

Issue and/or context: As tracked on issue single-cell-data/TileDB-SOMA#2407 [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in single-cell-data/TileDB-SOMA#2407

Changes:

Notes for Reviewer:

@johnkerl johnkerl force-pushed the kerl/new-shape-docstrings branch from 494864a to dabc8dd Compare December 4, 2024 19:16
Copy link
Copy Markdown

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ltgm. Minor typing suggestions.

Comment thread python-spec/src/somacore/data.py
Comment thread python-spec/src/somacore/data.py
@johnkerl
Copy link
Copy Markdown
Contributor Author

johnkerl commented Dec 4, 2024

@nguyenv alas on my most recent commit I get

python-spec/src/somacore/data.py:176: error: X | Y syntax for unions requires Python 3.10  [syntax]
python-spec/src/somacore/data.py:310: error: X | Y syntax for unions requires Python 3.10  [syntax]
Found 2 errors in 1 file (checked 21 source files)

@johnkerl johnkerl merged commit e49776b into main Dec 4, 2024
@johnkerl johnkerl deleted the kerl/new-shape-docstrings branch December 4, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants