Sync domain argument between Collection.add_new_dataframe and DataFrame.create#233
Merged
Sync domain argument between Collection.add_new_dataframe and DataFrame.create#233
domain argument between Collection.add_new_dataframe and DataFrame.create#233Conversation
johnkerl
force-pushed
the
kerl/add-new-dataframe-domain
branch
from
4d09188 to
6c90815
Compare
nguyenv
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue single-cell-data/TileDB-SOMA#2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
The
Collection.add_new_dataframeis syntactic sugar onDataFrame.create. The latter takes an optionaldomainargument, so the former should as well.This is not only generally important for single-cell-data/TileDB-SOMA#2407; it is specifically for the cellxgene census builder which uses
add_new_dataframeexclusively.Notes for Reviewer: