Fix Node engine V8 compatibility#26
Closed
Borewit wants to merge 1 commit into
Closed
Conversation
This was referenced Jan 12, 2020
Owner
|
The linter and test runner requires that version. I could of course remove Node.js 8 from Travis, but then I can not be sure I don't accidentally use any non-Node.js 8 APIs or syntax. I would suggest just staying with the previous In general, I think it's more than generous for maintains to target the LTS versions. Personally, I wish I could target latest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing Node engine requirements, which is currently set unnecessary high, breaking Node engine V8 compatibility of this module and all it's dependants.