Add ability to control number of fractional digits by nmoinvaz · Pull Request #62 · sindresorhus/pretty-bytes

nmoinvaz · 2020-08-30T20:32:20Z

This should resolve #57.

nmoinvaz · 2020-08-31T01:36:20Z

I can remove fixed option if you don't want it.

readme.md

index.js

readme.md

index.d.ts

test.js

sindresorhus · 2020-12-23T07:10:03Z

What's the use-case for the fixed option?

nmoinvaz · 2021-01-02T03:38:35Z

There was no use case for fixed, I just added it as an alternative to precision for completeness. I will remove it.

nmoinvaz · 2021-01-02T03:41:41Z

It appears the proper way to do this is not through toFixed or toPrecision but through locale options when calling number.toLocaleString(locale, options). I can expose a localeOptions option which would allow users to set it through localeOptions: {minimumFractionDigits: 2, maximumFractionDigits: 2}, or I can keep with the digits options digits: 2 with a note that using digits will automatically format the number using the system default locale.

nmoinvaz · 2021-01-02T04:30:52Z

I have tried both ways, in two commits. I think the last commit is the best that has a localeOptions which is more configurable because both minimumFractionDigits and maximumFractionDigits can be set if desired.

index.d.ts

sindresorhus · 2021-01-07T08:50:38Z

I agree with minimumFractionDigits and maximumFractionDigits, but they should be top-level options, not nested in localeOptions. And you need to document their default values.

nmoinvaz · 2021-01-08T01:15:31Z

The default values will be undefined because the when minimumFractionDigits and maximumFractionDigits is not set it will default to toPrecision(3) which has entirely different behavior.

…its.

nmoinvaz · 2021-01-08T02:06:48Z

Actually if you meant default value in the Object.assign for options, then I have included it.

nmoinvaz · 2021-01-08T02:07:29Z

Requested changes have been made again.

sindresorhus · 2021-01-17T10:27:10Z

index.js

@@ -58,7 +58,7 @@ const toLocaleString = (number, locale, options) => {
 	let result = number;


It would be better to just do options = {}.

Then I would check Object.keys(options).length > 0 in the second if statement?

index.js

readme.md

index.d.ts

sindresorhus · 2021-01-17T20:22:15Z

index.js

+
 	if (number < 1) {
-		const numberString = toLocaleString(number, options.locale);
+		const numberString = toLocaleString(number, options.locale, localeOptions);


Suggested change

const numberString = toLocaleString(number, options.locale, localeOptions);

const numberString = toLocaleString(number, options.locale, {

...{

options.minimumFractionDigits,

options.maximumFractionDigits

}

});

localeOptions should be undefined if both minimumFractionDigits and maximumFractionDigits is not set - so that it does not get localized by toLocaleString.

test.js

nmoinvaz · 2021-01-22T04:03:23Z

Some of the requested changes have been made.

nmoinvaz marked this pull request as draft August 30, 2020 20:44

nmoinvaz force-pushed the features/precision branch from 26c3b96 to 22b92c7 Compare August 30, 2020 21:19

nmoinvaz changed the title ~~Added precision/digits option.~~ Added digits and fixed options. Aug 30, 2020

nmoinvaz marked this pull request as ready for review August 30, 2020 21:21

sindresorhus requested changes Dec 23, 2020

View reviewed changes

sindresorhus changed the title ~~Added digits and fixed options.~~ Add digits and fixed options Dec 23, 2020

nmoinvaz force-pushed the features/precision branch 5 times, most recently from 8d64572 to 9ddc532 Compare January 2, 2021 04:28

nmoinvaz changed the title ~~Add digits and fixed options~~ Add ability to control number of fractional digits displayed Jan 2, 2021

nmoinvaz force-pushed the features/precision branch 2 times, most recently from d75314f to 1bbce52 Compare January 2, 2021 04:36

nmoinvaz requested a review from sindresorhus January 2, 2021 04:37

nmoinvaz and others added 2 commits January 1, 2021 20:40

Added digits option to control locale fraction options.

4b9db65

Control number of fraction digits through localeOptions option.

e19c385

nmoinvaz force-pushed the features/precision branch from 1bbce52 to e19c385 Compare January 2, 2021 04:40

sindresorhus reviewed Jan 7, 2021

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

Convert localeOptions to minimumFractionDigits and maximumFractionDig…

5640ac7

…its.

nmoinvaz force-pushed the features/precision branch from c2bd721 to 5640ac7 Compare January 8, 2021 02:05

nmoinvaz requested a review from sindresorhus January 8, 2021 02:07

sindresorhus requested changes Jan 17, 2021

View reviewed changes

nmoinvaz added 5 commits January 21, 2021 19:42

Don't set default value for option with undefined default.

30358d1

Add default behavior for fraction digit options.

2265783

Add example of not using fraction digit options.

df1c169

Sync readme and index changes.

fe9ca41

Added more fraction tests.

a245d3f

nmoinvaz requested a review from sindresorhus January 22, 2021 04:03

Base automatically changed from master to main January 24, 2021 06:04

sindresorhus added 3 commits February 21, 2021 20:47

Update readme.md

ab8dad7

Update test.js

c7f55a7

Update index.d.ts

5efb81b

sindresorhus changed the title ~~Add ability to control number of fractional digits displayed~~ Add ability to control number of fractional digits Feb 21, 2021

sindresorhus merged commit 8388e69 into sindresorhus:main Feb 21, 2021

dependabot bot mentioned this pull request Mar 11, 2021

chore(deps-dev): bump pretty-bytes from 5.5.0 to 5.6.0 sergioramos/serverless-plugin-tree-shake#141

Closed

hashim21223445 mentioned this pull request Jun 12, 2024

[Snyk] Upgrade pretty-bytes from 5.3.0 to 5.6.0 hashim21223445/platform-samples#16

Closed

snyk-io bot mentioned this pull request Jul 19, 2024

[Snyk] Upgrade pretty-bytes from 5.3.0 to 6.1.1 Morin3/Hcc12#21

Open

This was referenced Jul 29, 2024

[Snyk] Upgrade pretty-bytes from 5.3.0 to 5.6.0 hashim21223445/Andoka-Bitbucket-#6

Merged

[Snyk] Upgrade pretty-bytes from 5.3.0 to 5.6.0 hashim21223445/Andoka-pro-#1

Merged

X-oss-byte mentioned this pull request Sep 8, 2024

[Snyk] Upgrade: , commander, inquirer, moment, octokit, pretty-bytes, terminal-kit X-oss-byte/GitHubapi#296

Open

X-oss-byte mentioned this pull request Sep 16, 2024

[Snyk] Upgrade: , commander, inquirer, moment, octokit, pretty-bytes, terminal-kit X-oss-byte/GitHubapi#300

Open

		@@ -58,7 +58,7 @@ const toLocaleString = (number, locale, options) => {
		let result = number;

-		const numberString = toLocaleString(number, options.locale, localeOptions);
+		const numberString = toLocaleString(number, options.locale, {
+			...{
+				options.minimumFractionDigits,
+				options.maximumFractionDigits
+			}
+		});

Uh oh!

Comments

Conversation

nmoinvaz commented Aug 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nmoinvaz commented Aug 31, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sindresorhus commented Dec 23, 2020

Uh oh!

nmoinvaz commented Jan 2, 2021

Uh oh!

nmoinvaz commented Jan 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nmoinvaz commented Jan 2, 2021

Uh oh!

Uh oh!

sindresorhus commented Jan 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nmoinvaz commented Jan 8, 2021

Uh oh!

nmoinvaz commented Jan 8, 2021

Uh oh!

nmoinvaz commented Jan 8, 2021

Uh oh!

sindresorhus Jan 17, 2021

Choose a reason for hiding this comment

Uh oh!

nmoinvaz Jan 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sindresorhus Jan 17, 2021

Choose a reason for hiding this comment

Uh oh!

nmoinvaz Jan 22, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nmoinvaz commented Jan 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nmoinvaz commented Aug 30, 2020 •

edited

Loading

nmoinvaz commented Jan 2, 2021 •

edited

Loading

sindresorhus commented Jan 7, 2021 •

edited

Loading

nmoinvaz Jan 22, 2021 •

edited

Loading