Add raw codeFrame and fix JSONError type #37
Merged
+32
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Aug 31, 2023
test.js
Outdated
| parseJson('{\n\t"foo": true,\n}', 'foo.json'); | ||
| } catch (error) { | ||
| t.assert(error.codeFrame); | ||
| t.true(error.rawCodeFrame === ' 1 | {\n 2 | \t"foo": true,\n> 3 | }\n | ^'); |
Owner
|
You need to add it to the readme and index.d.ts |
Owner
|
This was already merged and released. |
SmushyTaco
pushed a commit
to SmushyTaco/parse-json
that referenced
this pull request
Jan 15, 2025
Co-authored-by: Sindre Sorhus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needed to get the code lines without the highlighting, so I have introduced a new property for it.
Also fixes JSONError to be a class so that the
instanceofcomparison can be used in a Typescript codebase.