Skip to content

Conversation

@tommy-mitchell
Copy link
Contributor

Not sure if I missed anything in the definitions. Updating the dependencies doesn't seem to have any breaking changes.

@tommy-mitchell
Copy link
Contributor Author

...nevermind, guess something doesn't like Node 19

@tommy-mitchell
Copy link
Contributor Author

Here's the error:

Details
✘ [fail]: main
✔ throws exported error error
─

main

test.js:9

 8:                                       
 9:   t.throws(() => {                    
 10:     parseJson('{\n\t"foo": true,\n}');

Function threw unexpected exception:

ErrorEXError {
  codeFrame: `  1 | {␊
    2 | 	"foo": true,␊
  > 3 | }␊
      | ^`,
  name: 'JSONError',
}

Expected message to match:

/Unexpected token "}"/

› | ^
› parseJson (file://index.js:28:21)
› t.throws.name (file://test.js:10:3)
› file://test.js:9:4

─

1 test failed

@sindresorhus
Copy link
Owner

I generally don't test on non-LTS Node.js versions as they're generally buggy and end up with too many temporary failures.

@sindresorhus sindresorhus merged commit c4d2319 into sindresorhus:main Apr 7, 2023
SmushyTaco pushed a commit to SmushyTaco/parse-json that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants