Fix dependency on lines-and-columns
#33
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I messed up the minor updates I was making to `lines-and-columns` to use ES modules only, and published a patch update (v1.1.7) instead of a major one (v2.0.0). This had way more downstream effects than I intended. As I couldn't unpublish, I ended up publishing v1.1.9 to fix the issue, but that also included ESM support, but I realize now that was probably a mistake too since it represents a breaking change for anything using ESM itself. This fixes it for `parse-json` by updating to the v2.0.2 ESM version.
Contributor
Author
|
This is less urgent now that I've published v1.1.10 and v1.2.3 which remove the ESM build. By default |
sindresorhus
changed the title
lines-and-columns.lines-and-columns
|
still is not working. it's not eliminating \n @eventualbuddha |
SmushyTaco
pushed a commit
to SmushyTaco/parse-json
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up the minor updates I was making to
lines-and-columnsto use ES modules only, and published a patch update (v1.1.7) instead of a major one (v2.0.0). This had way more downstream effects than I intended. As I couldn't unpublish, I ended up publishing v1.1.9 to fix the issue, but that also included ESM support, but I realize now that was probably a mistake too since it represents a breaking change for anything using ESM itself.This fixes it for
parse-jsonby updating to the v2.0.2 ESM version. Alternatively, you could pin v1.1.6.