Fix TypeError retry handling

sindresorhus · sindresorhus · commit f011d2e83716 · 2026-01-25T11:40:44.000+07:00
diff --git a/index.d.ts b/index.d.ts
@@ -221,6 +221,8 @@ Returns a `Promise` that is fulfilled when calling `input` returns a fulfilled p
 
 Does not retry on most `TypeErrors`, with the exception of network errors. This is done on a best case basis as different browsers have different [messages](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#Checking_that_the_fetch_was_successful) to indicate this. See [whatwg/fetch#526 (comment)](https://github.com/whatwg/fetch/issues/526#issuecomment-554604080)
 
+Non-network `TypeError`s always abort retries, even if `shouldConsumeRetry` or `shouldRetry` would otherwise allow another attempt.
+
 @param input - Receives the number of attempts as the first argument and is expected to return a `Promise` or any value.
 @param options - Options for configuring the retry behavior.
 
diff --git a/index.js b/index.js
@@ -129,12 +129,7 @@ async function onAttemptFailure({error, attemptNumber, retriesConsumed, startTim
 	}
 
 	if (normalizedError instanceof TypeError && !isNetworkError(normalizedError)) {
-		if (consumeRetry) {
-			throw normalizedError;
-		}
-
-		options.signal?.throwIfAborted();
-		return false;
+		throw normalizedError;
 	}
 
 	if (!await options.shouldRetry(context)) {
diff --git a/readme.md b/readme.md
@@ -37,6 +37,8 @@ Returns a `Promise` that is fulfilled when calling `input` returns a fulfilled p
 
 Does not retry on most `TypeErrors`, with the exception of network errors. This is done on a best case basis as different browsers have different [messages](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#Checking_that_the_fetch_was_successful) to indicate this. See [whatwg/fetch#526 (comment)](https://github.com/whatwg/fetch/issues/526#issuecomment-554604080)
 
+Non-network `TypeError`s always abort retries, even if `shouldConsumeRetry` or `shouldRetry` would otherwise allow another attempt.
+
 #### input
 
 Type: `Function`
diff --git a/test.js b/test.js
@@ -82,6 +82,24 @@ test('shouldRetry is not called for non-network TypeError', async t => {
 	t.is(shouldRetryCalled, 0);
 });
 
+test('does not retry non-network TypeError when shouldConsumeRetry returns false', async t => {
+	const typeErrorFixture = new TypeError('type-error-fixture');
+	let attempts = 0;
+
+	await t.throwsAsync(pRetry(async () => {
+		attempts++;
+		throw typeErrorFixture;
+	}, {
+		shouldConsumeRetry() {
+			return false;
+		},
+		retries: 5,
+		minTimeout: 0,
+	}), {is: typeErrorFixture});
+
+	t.is(attempts, 1);
+});
+
 test('retry on TypeError - failed to fetch', async t => {
 	const typeErrorFixture = new TypeError('Failed to fetch');
 	let index = 0;
@@ -1362,7 +1380,7 @@ test.serial('Only consumed retries advance backoff', async t => {
 			attempts++;
 
 			if (attempts === 1) {
-				throw new TypeError('skip');
+				throw new Error('skip');
 			}
 
 			if (attempts === maxAttempts) {

Original file line number	Diff line number	Diff line change
`@@ -129,12 +129,7 @@ async function onAttemptFailure({error, attemptNumber, retriesConsumed, startTim`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`if (normalizedError instanceof TypeError && !isNetworkError(normalizedError)) {`
`132`		`- if (consumeRetry) {`
`133`		`- throw normalizedError;`
`134`		`- }`
`135`		`-`
`136`		`- options.signal?.throwIfAborted();`
`137`		`- return false;`
	`132`	`+ throw normalizedError;`
`138`	`133`	`}`
`139`	`134`
`140`	`135`	`if (!await options.shouldRetry(context)) {`